Skip to content

PB-2064: fix featureSelection cypress test #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sommerfe wants to merge 7 commits into
base: fix-pb-2026-fix-import-tool-file
Choose a base branch
from
Open

PB-2064: fix featureSelection cypress test #1528

sommerfe wants to merge 7 commits into from

Conversation

@sommerfe
Copy link
Contributor

@sommerfe sommerfe commented Dec 5, 2025 •
edited by github-actions bot
Loading

@sommerfe sommerfe self-assigned this Dec 5, 2025
@github-actions github-actions bot added the bug label Dec 5, 2025
@cypress
Copy link

cypress bot commented Dec 5, 2025 •
edited
Loading

web-mapviewer    Run #6179

Run Properties:  status check errored Errored #6179  •  git commit 94bd33a30d: PB-2064: fix test
Project web-mapviewer
Branch Review fix-pb-2064-feature-selection
Run status status check errored Errored #6179
Run duration 10m 13s
Commit git commit 94bd33a30d: PB-2064: fix test
Committer Felix Sommer
View all properties for this run ↗︎
Test results
Tests that failed  Failures 45
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 20
Tests that did not run due to a failure in a mocha hook  Skipped 1
Tests that passed  Passing 160
View all changes introduced in this branch ↗︎

Tests for review

Failed  drawing.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay Screenshots
Failed  legacyParamImport.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay Screenshots
Failed  changeLanguage.cy.ts • 3 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Change language > on startup > should show the correct language if we ask for it, even if the param is in uppercase Test Replay Screenshots
Change language > in mobile view > should change the language Test Replay Screenshots
Change language > in desktop view > should change the language Test Replay Screenshots
Failed  layers.cy.ts • 11 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Test of layer handling > Layer in URL at app startup > adds a layers with config to the map when opening the app layers URL param Test Replay Screenshots
Test of layer handling > Layer in URL at app startup > uses the default timestamp of a time enabled layer when not specified in the URL Test Replay Screenshots
Test of layer handling > Layer in URL at app startup > sets the timestamp of a layer when specified in the layers URL param Test Replay Screenshots
... > reads and adds an external WMS correctly Test Replay Screenshots
... > reads and adds an external WMTS correctly Test Replay Screenshots
... > reads and adds an external WMTS correctly but doesn't show the invisible layer Test Replay Screenshots
Test of layer handling > Background layer in URL at app startup > sets the background to the void layer if we set the bgLayer parameter to "void" Test Replay Screenshots
Test of layer handling > Background layer in URL at app startup > sets the background to the topic default if none is defined in the URL, even if a layer (out of topic scope) is defined in it Test Replay Screenshots
... > layer with timestamp can be configured Test Replay Screenshots
... > Reorder layers using the "move" button Test Replay Screenshots
The first 10 failed tests are shown, see all 11 tests in Cypress Cloud.
Failed  importToolMaps.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay Screenshots

The first 5 failed specs are shown, see all 20 specs in Cypress Cloud.

@sommerfe sommerfe force-pushed the fix-pb-2064-feature-selection branch 6 times, most recently from 5481241 to d4fb89a Compare December 8, 2025 14:37
@sommerfe sommerfe changed the base branch from fix-pb-2064-is-map-ready to fix-pb-2026-fix-import-tool-file December 8, 2025 14:46
ismailsunni and others added 6 commits December 8, 2025 15:49
@ismailsunni @sommerfe
PB-2064: Fix makeGPXLayer missing gpxFileUrl.
0bf5f41
@pakb @sommerfe
PB-2064: fix GPX drag&drop and Cesium artifacts
2a355f0 
while debugging a GPX file from a user, I fixed two issues regarding 3D and GPX:
 - 3D viewer had some artifacts on the terrain tiles, I disabled some post-processing operation and they were gone
 - the GPX file parser wasn't giving any "gpxFileUrl" for local files, and the creation of the layer was raising an error (failing the parsing)
@sommerfe
PB-2064: fix map ready state parsed legacy state
deacc5d
@sommerfe
PB-2064: fix featureSelection cypress test
6e2cf81
@sommerfe
PB-2064: fix feature selection test
e493065
@sommerfe
PB-2064: fix feature selection tests
e0fea36
@sommerfe sommerfe force-pushed the fix-pb-2064-feature-selection branch 3 times, most recently from 0277e35 to 0d14bac Compare December 9, 2025 06:30
@sommerfe sommerfe force-pushed the fix-pb-2064-feature-selection branch from 0d14bac to 94bd33a Compare December 9, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sommerfe sommerfe

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sommerfe @ismailsunni @pakb